search

fungus75 / ReadOnlyAccessBundle

Read Only Access Plugin for Kimai
MIT License
4 stars 6 forks source link

import not working due to actions.html.twig renamed in kimai2 base-project #2

Open ionics opened 4 years ago

ionics commented 4 years ago

actions.html.twig got removed in kimai2

request.CRITICAL: Uncaught PHP Exception Twig\Error\LoaderError: "Unable to find template "macros/actions.html.twig"

yehudahkay commented 4 years ago

It is possible to fix by updating to user/actions.html.twig in the templates

ionics commented 4 years ago

as yehudahkay statet: just replace in file: /kimai2/var/plugins/ReadOnlyAccessBundle/Resources/views/showCustomerTimes.html.twig -{% import "macros/actions.html.twig" as actions %} +{% import "user/actions.html.twig" as actions %}

seems file has moved... lets keep this BUG open until project owner can update the issue.

rafaelgou commented 4 years ago

See #4 . Actually the macro is not used, can be removed.

Here's a pull request:https://github.com/fungus75/ReadOnlyAccessBundle/pull/5

stephankellermayr commented 4 years ago

I think it should be {% import "activity/actions.html.twig" as actions %}, but it is not required and {% import "macros/toolbar.html.twig" as toolbar %} can be removed too in index.html.twig and showCustomerTimes.twig.html. Created another PR, @fungus75 please merge this!

fungus75 commented 4 years ago

Hi @stephankellermayr , just merged your PR. Guess this issue is fixed by now?