funilrys / PyFunceble

The tool to check the availability or syntax of domain, IP or URL.
https://pyfunceble.github.io
Apache License 2.0
297 stars 44 forks source link

BUG: idna conversion with --adblock #289

Closed spirillen closed 2 years ago

spirillen commented 2 years ago

Description

Was testing this zone https://github.com/dns-test/iploggerfilter/blob/master/filterlist with the adblocker enabled.

Related issues to this use case

The issue:

In the INVALID Pyfunceble have converted ||yoütu.be^$important,all to xn--||yotu-6ya.be^$important,all

Configuration

https://mypdns.org/spirillen/PyFunceble/-/snippets/50

Reproduction

  1. pyfunceble -f https://github.com/dns-test/iploggerfilter/blob/master/filterlist --adblock
  2. See the attachments in https://github.com/piperun/iploggerfilter/issues/50

Expected behavior

No errors

Screenshots

Versions

OS: Ubuntu focal

Python Version: 3.10

PyFunceble Version: pyfunceble 4.1.0b5.dev

Additional context

Not for now

spirillen commented 2 years ago

A side note to this

I'm starting to get a lot of these lines

image

funilrys commented 2 years ago

Hey @spirillen,

I can't reproduce this ...

$ pyfunceble --version
pyfunceble 4.1.0b7.dev (Blue Duckling: Grandiflora)
$  cat list.test 
||äxample.com^
||yoütu.be^$important,all
$ pyfunceble -f list.test --adblock --syntax --simple
xn--xample-9ta.com VALID
xn--yotu-1ra.be VALID

Status      Percentage   Amount      
----------- ------------ ------------
VALID       100%         2           
INVALID     0%           0           

Cheers!

spirillen commented 2 years ago

Hmm couldn't reproduce my self on this device, only on the other one, but that one is busy testing https://github.com/ShadowWhisperer/BlockLists/blob/master/Lists/Adult

Will get back when I've been able to rerun the test

funilrys commented 2 years ago

Ping

spirillen commented 2 years ago

Pong...

Saw them a few days ago, those erllib3..

Bit haven't seen the other issue since.

funilrys commented 2 years ago

Closing. Feel free to reopen if necessary.