search

funilrys / PyFunceble

The tool to check the availability or syntax of domain, IP or URL.
https://pyfunceble.github.io
Apache License 2.0
289 stars 44 forks source link

BUG: CI duble testing same domain #372

Open spirillen opened 1 week ago

spirillen commented 1 week ago

Description

To understand my question/observation we have to look at these to GHA

  1. https://github.com/mypdns/matrix/actions/runs/9656304178/job/26633593189#step:6:166
  2. https://github.com/mypdns/matrix/actions/runs/9656341145/job/26633690610#step:6:166

As you now can see, then the two CI are testing the same domains. Now why is this weird, the sources are the same, yes. but they are pushing the test results to a central mariadb.

Configuration

Please see https://github.com/mypdns/matrix/blob/e42eba13fb4b7da22c10408362e9891c5d8fd0df/.pyfunceble/.PyFunceble.overwrite.yaml

Reproduction

  1. Run the CI with an external DB

Expected behavior

I would have expected that we don't keep testing the same records again and again as we uses a central DB to store the results. As the one CI started a couple of minutes earlier.

Screenshots

Not needed

Versions

OS: ubuntu-latest

Python Version: 3.12

PyFunceble Version: 4.2.4-dev

Additional context

I will suggest a workflow like

  1. -c --preload = Read date from source
  2. write new data to db
  3. Read data to test
  4. Test that data
  5. Write test result to DB
  6. repeat from 3 till the end
spirillen commented 1 week ago

And a 3rd run, the same data again

https://github.com/mypdns/matrix/actions/runs/9656558435/job/26634259933#step:6:167