funjack / launchcontrol

Launchcontrol is a server that can control/playback scripts on a Launch

BSD 3-Clause "New" or "Revised" License

22 stars 3 forks source link

bugfix: i is probably supposed go from 1..3 not 0..2 #24

Closed ghost closed 5 years ago

ghost commented 5 years ago

I don't think it was intended that "i" would go from 0..2 because if "i" is 0 it seems like the following if statement always equates to true in its first iteration after sleeping for 1 second when "i" is 0. if round(self.getTime()) > round(eventTime+waitTimeSec*i):

The addon and the server works great btw, just stumbled upon this while looking through the code. first time using github be gentle lol

codecov[bot] commented 5 years ago

Codecov Report

Merging #24 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   87.29%   87.29%           
=======================================
  Files          13       13           
  Lines         543      543           
=======================================
  Hits          474      474           
  Misses         47       47           
  Partials       22       22

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e627746...f639a0a. Read the comment docs.

funjack commented 5 years ago

Thanks, good catch!

Although I'm wondering how relevant this code is today. I added this 'ugly work-around', since resuming full-hd movies on an older RaspberryPi got all out of sync. Re-reading my own comments again really showed how fed up I was with it at the time :)

Still, great to hear it's working out for you.