search

funkelab / daisy

Block-wise task scheduling for large nD volumes.
MIT License
25 stars 16 forks source link

remove funlib library commit hash #40

Closed pattonw closed 1 year ago

pattonw commented 1 year ago

Using the commit hash makes it difficult to write libraries that depend on daisy and funlib packages without specifying the exact same hash.

For example including "funlib.math @ git+https://github.com/funkelab/funlib.math" and "daisy" in a new package setup.py instal_requires results in the following error message:

The conflict is caused by:
    {your package} depends on funlib-math 0.1 (from git+https://github.com/funkelab/funlib.math)
    daisy 1.0 depends on funlib-math 0.1 (from git+https://github.com/funkelab/funlib.math@0c623f71c083d33184cac40ef7b1b995216be8ef)
trivoldus28 commented 1 year ago

Maybe in this case it's better to specify the version of the math package to be 0.1 on both packages? This is because I remember there was behavior breaking changes in the math package (or something similar) and so it's important to specify version or commit hash.

pattonw commented 1 year ago

hmm, not sure the best way to do this. maybe git tags?

trivoldus28 commented 1 year ago

I think just something like funlib-math=>0.1

pattonw commented 1 year ago

I think that would be annoying since funlib-math is not published on pypi. So when you go to install daisy you will get the following error:

ERROR: Could not find a version that satisfies the requirement funlib.math>=0.1 (from daisy) (from versions: none)
ERROR: No matching distribution found for funlib.math>=0.1
trivoldus28 commented 1 year ago

yea so a tag could be used, but it would just be pinning the dep libs to specific versions which is not great. For now I think we can remove the commit hash but we should try to publish the libs on pypi asap and utilize the versioning capability