search

funkelab / daisy

Block-wise task scheduling for large nD volumes.
MIT License
25 stars 16 forks source link

Tcp timeout #46

Open rhoadesScholar opened 5 months ago

rhoadesScholar commented 5 months ago

Timeout for tcp messaging was hardcoded to 0.1, which empirically resulted in excessive worker terminations, drastically slowing processing.

Originally a "timeout" kwarg was included for Task() definition, but this information is not currently applied in the master branch code.

I found it more appropriate and parsimonious to include a "tcp_timeout" kwarg in the convenience.run_blockwise() call that initializes scheduling of tasks.

rhoadesScholar commented 5 months ago

Note: Current master branch also fails mypy.

pattonw commented 3 months ago

The ubuntu tests seem to fail after a 6hr timeout, I don't see any changes that would would result in hanging forever though