random_loc: shifts are valid if at least one coordinate is non-zero

funkelab / gunpowder

A library to facilitate machine learning on multi-dimensional images.

https://funkelab.github.io/gunpowder/

MIT License

79 stars 56 forks source link

random_loc: shifts are valid if at least one coordinate is non-zero #122

Closed abred closed 4 years ago

abred commented 4 years ago

roi: remove .empty shortcut in intersects empty is true if any component in shape is zero. for random location there can be valid shifts even if a subset of components are zero (as long as one is non-zero)

pattonw commented 4 years ago

This has been worked on in patch-1.1.6. I'll include those fixes in the dev branch as well when we merge patch-1.1.6 into master.

abred commented 4 years ago

Where does patch-1.1.6 fit into the v1.X-dev naming scheme?

pattonw commented 4 years ago

There's 1.1 which is the current stable release (master). There's 1.2 with extra features under development (v1.2-dev). Bugs in the stable release should be fixed on a patch branch off of master (patch-1.1.6), merged into master, and then propagated forward into 1.2 as well.