In NoiseAugment, call assert for data in [0, 1] only if clip is True

Steffen-Wolf commented 3 years ago

Just a small fix that removes an unnecessary assert in NoiseAugment.

Calling NoiseAugment for data that is not in the range of [0, 1] should be possible. Noise augment warps skimage.util.random_noise internally, that can handle any input range.

For clip==False there should be no assert in any case. I have left the assert in place for when clip==True as it seems reasonable. Note however that this creates an arbitrary restriction. Even for clip==True, skimage.util.random_noise can handle inputs outside of the range [0,1] it just clips the output after adding the noise.

Pre-Merge Checklist:

[no] if this PR adds a feature: request merge into the latest development branch (vX.Y-dev)
[no] if this PR fixes a bug: request merge into the latest patch branch (patch-X.Y.Z)
[yes] PR branch name is short and describes the feature/bug addressed in this PR
[yes] commit messages are consistent
[not yet] changes reviewed by another contributor
[yes] tests cover changes
[not tested] all tests pass

pattonw commented 2 years ago

Seems reasonable to move the assert. I agree that the assert seems overkill. Maybe we could just change it to a warning or a debugging message?

pattonw commented 2 years ago

Otherwise can probably go ahead and merge this

pattonw commented 2 years ago

merged into the patch-1.2.3 branch

funkelab / gunpowder

In NoiseAugment, call assert for data in [0, 1] only if clip is True #153