Closed rhoadesScholar closed 2 years ago
Tests written and passed for Resample and AsType.
Pull Request out of date and the main author on paternity leave until 01/17/2022. Will be splitting off updates unrelated to AsType and Resample nodes at that time into a separate pull request.
Thank you for your feedback/interest.
Just a few quick changes and we can go ahead and merge:
1) Since you're adding new features can you target it at the patch-1.2.3? That will make it easier for @funkey when he eventually needs to update a new release.
2) Can you add these nodes to the docs. You can do that in the docs/build/api.rst
file: https://github.com/funkey/gunpowder/blob/master/docs/build/api.rst
Just a few quick changes and we can go ahead and merge:
- Since you're adding new features can you target it at the patch-1.2.3? That will make it easier for @funkey when he eventually needs to update a new release.
- Can you add these nodes to the docs. You can do that in the
docs/build/api.rst
file: https://github.com/funkey/gunpowder/blob/master/docs/build/api.rst
No need to re-generate the HTML, Jan will do that when he creates a new release. This all looks good and ready to merge
Adds "Resample" node to resample arrays to a user-designated voxel size, using skimage.transform.rescale
Pre-Merge Checklist:
vX.Y-dev
)patch-X.Y.Z
)