This PR puts the __add__ and __radd__ methods directly on BatchProvider, rather than dynamically monkeypatching it when pipeline.py is imported. This makes it easier to inspect, and appeases type checkers that yell at you when you try to add a tuple of Source objects to a BatchProvider:
Pre-Merge Checklist:
[x] if this PR fixes a bug: request merge into the latest patch branch (patch-X.Y.Z)
[x] PR branch name is short and describes the feature/bug addressed in this PR
note: i branched off of master ... which seems to be the cause for the change in setup.py (when merging into patch-1.2.3) ... let me know if I should be merging to something else.
also, couldn't run all tests locally on mac due to the subprocess issue that I think @pattonw was fixing at dl@mbl ... and it doesn't look like the travis tests are running here?
This PR puts the
__add__and__radd__methods directly onBatchProvider, rather than dynamically monkeypatching it whenpipeline.pyis imported. This makes it easier to inspect, and appeases type checkers that yell at you when you try to add a tuple ofSourceobjects to aBatchProvider:Pre-Merge Checklist:
patch-X.Y.Z)note: i branched off of
master... which seems to be the cause for the change in setup.py (when merging into patch-1.2.3) ... let me know if I should be merging to something else.also, couldn't run all tests locally on mac due to the subprocess issue that I think @pattonw was fixing at dl@mbl ... and it doesn't look like the travis tests are running here?