Update pad.py to include reflective padding

funkelab / gunpowder

A library to facilitate machine learning on multi-dimensional images.

https://funkelab.github.io/gunpowder/

MIT License

78 stars 56 forks source link

Update pad.py to include reflective padding #195

Closed lmanan closed 11 months ago

lmanan commented 1 year ago

Pre-Merge Checklist:

[x] if this PR adds a feature: request merge into the latest development branch (vX.Y-dev)
[ ] if this PR fixes a bug: request merge into the latest patch branch (patch-X.Y.Z)
[x] PR branch name is short and describes the feature/bug addressed in this PR
[ ] commit messages are consistent
[ ] changes reviewed by another contributor
[ ] tests cover changes
[ ] all tests pass

This PR adds capability for enabling reflection-padding in pad.py here.

pattonw commented 1 year ago

Can you add tests? What happens if the padded region is larger than the contained region along some axis?

pattonw commented 1 year ago

Also please target the patch-1.3.2 branch for your pull request

codecov-commenter commented 1 year ago

Codecov Report

Merging #195 (d721190) into main (a33e5b4) will decrease coverage by 0.12%. The diff coverage is 27.77%.

@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   67.60%   67.48%   -0.12%     
==========================================
  Files          98       98              
  Lines        6829     6844      +15     
==========================================
+ Hits         4617     4619       +2     
- Misses       2212     2225      +13

Files	Coverage Δ
gunpowder/nodes/pad.py	`76.00% <27.77%> (-15.67%)`	:arrow_down:

pattonw commented 11 months ago

closing in favor of https://github.com/funkelab/gunpowder/pull/197 That pull request targets the patch branch and includes tests