fix undefined padded - Githubissues

funkelab / gunpowder

A library to facilitate machine learning on multi-dimensional images.

https://funkelab.github.io/gunpowder/

MIT License

79 stars 56 forks source link

fix undefined padded #203

Closed mzouink closed 9 months ago

mzouink commented 9 months ago

Pre-Merge Checklist:

[ ] if this PR adds a feature: request merge into the latest development branch (vX.Y-dev)
[ ] if this PR fixes a bug: request merge into the latest patch branch (patch-X.Y.Z)
[ ] PR branch name is short and describes the feature/bug addressed in this PR
[ ] commit messages are consistent
[ ] changes reviewed by another contributor
[ ] tests cover changes
[ ] all tests pass

mzouink commented 9 months ago

@pattonw

cmalinmayor commented 9 months ago

To summarize in-person discussion: The case of a user passing in an incorrect padding mode should still raise an error, but we should make a more informative error message, rather than letting it fail upstream and raise a padding is Undefined error. Something like:


elif:
    raise ValueError("Invalid padding mode %s provided. Must be 'constant' or 'reflect'." % self.mode)```

mzouink commented 9 months ago

@cmalinmayor i set a more informative bug

the black format test was failing because of many files. not just mine. should be good by now

cmalinmayor commented 9 months ago

Thanks @mzouink!