funkelab / gunpowder

A library to facilitate machine learning on multi-dimensional images.
https://funkelab.github.io/gunpowder/
MIT License
79 stars 56 forks source link

SimpleAugment transposes axes in the ROI request, instead of transposing the axes in the array #67

Closed bentaculum closed 4 years ago

bentaculum commented 5 years ago

If the global ROI is a subset of an entire dataset and therefore has three different offsets for x, y and z , the current transpose can lead to requests far away from the global ROI.

funkey commented 4 years ago

Fixed in https://github.com/funkey/gunpowder/commit/3b41136798e19fd80cd11bd00bbeb5d2243e2c44

Thanks for bringing this up!