search

funkelab / ilpy

Unified python wrappers for popular ILP solvers
https://funkelab.github.io/ilpy/
MIT License
3 stars 2 forks source link

change return type of Solver.solve from tuple to Solution instance #30

Closed tlambert03 closed 1 year ago

tlambert03 commented 1 year ago

closes #26 by changing the return type of Solver.solve from a tuple of (Solution, str) to just an instance of Solution ...

Solution gains a get_status() -> str method that can be used to recover the string.

This is a breaking API change.

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@70a2362). Click here to learn what that means. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage        ?   86.46%           
=======================================
  Files           ?        3           
  Lines           ?      303           
  Branches        ?        0           
=======================================
  Hits            ?      262           
  Misses          ?       41           
  Partials        ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

funkey commented 1 year ago

Thanks a lot! :)