search

funkelab / motile

Multi-Object Tracker using Integer Linear Equations
https://funkelab.github.io/motile/
MIT License
27 stars 5 forks source link

Improving error message when wrong frame is provided #120

Closed JoOkuma closed 2 months ago

JoOkuma commented 2 months ago

Hi @cmalinmayor,

We had some issues with this, and some users found it challenging to debug during the project week.

I noticed this is checked in add_nodes but not when creating from networkx.

LMK if you have any additional suggestions.

cmalinmayor commented 2 months ago

Thanks Jordao! This was on the TODO list (#91) but I never got around to it. I'll leave #91 open because I think we had plans to do something a bit more sophisticated around checking hyperedges, but this will be very helpful in the meantime!

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.92%. Comparing base (4d14bd6) to head (d445bc1). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
motile/track_graph.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #120 +/- ## ========================================== - Coverage 93.02% 92.92% -0.11% ========================================== Files 30 30 Lines 717 721 +4 ========================================== + Hits 667 670 +3 - Misses 50 51 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cmalinmayor commented 2 months ago

I'll look into the docs failing - I presume it has nothing to do with the actual change.