funkelab / motile

Multi-Object Tracker using Integer Linear Equations
https://funkelab.github.io/motile/
MIT License
24 stars 5 forks source link

Add typing and tests to the plot module #32

Closed tlambert03 closed 1 year ago

tlambert03 commented 1 year ago

does what the title says

codecov-commenter commented 1 year ago

Codecov Report

Merging #32 (e9273ad) into main (b8929ae) will increase coverage by 15.50%. The diff coverage is 94.73%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             main      #32       +/-   ##
===========================================
+ Coverage   77.12%   92.63%   +15.50%     
===========================================
  Files          28       28               
  Lines         752      692       -60     
===========================================
+ Hits          580      641       +61     
+ Misses        172       51      -121     
Impacted Files Coverage Δ
motile/plot.py 93.87% <94.44%> (+93.87%) :arrow_up:
motile/costs/features.py 81.81% <100.00%> (ø)
motile/solver.py 96.96% <100.00%> (+3.45%) :arrow_up:

... and 20 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tlambert03 commented 1 year ago

side note @funkey

I played with making is so that the plot is the default ipython repr of the track graph:

Screen Shot 2023-03-18 at 4 11 32 PM

... but removed it assuming it might be too much to do for a typical graph. But, it might be nice to make a draw() method on the track graph? it could take an optional solver argument to draw solution if not None?

tlambert03 commented 1 year ago

going to merge this one. @funkey I don't think you'll object, it doesn't change any functionality, just adds tests and typing