Closed bentaculum closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
56469ee
) 92.91% compared to head (1722dab
) 93.37%. Report is 6 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks a lot for that! This looks good to me, with the exception of constant
for EdgeDistance
. This can already by done through EdgeSelection
and would be redundant.
Good point. I removed this redundancy and updated the test accordingly.
Hi @funkey, ok to merge this?
Sorry for the delay. Yes, looks good, thanks a lot! :)
Split
andAppear
to theweight, attribute, constant
format of other costs. This now optionally allows for variable costs for these events.constant
theEdgeDistance
cost. Here the signature ispositional_attributes, weight, constant
, sincepositional_attributes
is a compulsory argument.