funkelab / motile

Multi-Object Tracker using Integer Linear Equations
https://funkelab.github.io/motile/
MIT License
24 stars 5 forks source link

Generalize costs #54

Closed bentaculum closed 8 months ago

bentaculum commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (56469ee) 92.91% compared to head (1722dab) 93.37%. Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #54 +/- ## ========================================== + Coverage 92.91% 93.37% +0.46% ========================================== Files 32 32 Lines 762 770 +8 ========================================== + Hits 708 719 +11 + Misses 54 51 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

funkey commented 1 year ago

Thanks a lot for that! This looks good to me, with the exception of constant for EdgeDistance. This can already by done through EdgeSelection and would be redundant.

bentaculum commented 1 year ago

Good point. I removed this redundancy and updated the test accordingly.

bentaculum commented 9 months ago

Hi @funkey, ok to merge this?

funkey commented 8 months ago

Sorry for the delay. Yes, looks good, thanks a lot! :)