search

funkelab / motile

Multi-Object Tracker using Integer Linear Equations
https://funkelab.github.io/motile/
MIT License
22 stars 4 forks source link

feat: add get_selected_subgraph #82

Closed tlambert03 closed 4 months ago

tlambert03 commented 4 months ago

one option to close #66

@funkey, would be nice to get your thoughts on this API. There are many ways and other places where this could be done (such as a motile.Solution object that is able to get selected, etc...)

also, please weigh in on method name. Not sure get_selected_solution is the best. cc @cmalinmayor

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 91.61%. Comparing base (aa49bf6) to head (5613843). Report is 4 commits behind head on main.

:exclamation: Current head 5613843 differs from pull request most recent head 7ec7976. Consider uploading reports for the commit 7ec7976 to get more accurate results

Files Patch % Lines
motile/solver.py 68.75% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #82 +/- ## ========================================== - Coverage 93.29% 91.61% -1.69% ========================================== Files 32 32 Lines 776 799 +23 ========================================== + Hits 724 732 +8 - Misses 52 67 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

funkey commented 4 months ago

Wonderful, this is very useful, thanks a lot! I'd suggest calling the function get_selected_subgraph to be a tad more precise (the solution can also contain other variables associated with nodes and edges).

tlambert03 commented 4 months ago

yes, I prefer get_selected_subgraph as well