search

funkemunky / AntiVPN

An antivpn utilizing the funkemunky API
Apache License 2.0
21 stars 7 forks source link

Fix PR #35 #42

Closed C0D3-M4513R closed 10 months ago

C0D3-M4513R commented 10 months ago

Btw, this could have been prevented, if you also enabled builds on a pull-request to master. e.g. I usually use:

on:
  push:
    branches: [main]
    tags:
      - v*
  pull_request:
    branches: [main]

(taken from https://github.com/C0D3-M4513R/DexProtectOscRS/blob/main/.github/workflows/rust.yml)

C0D3-M4513R commented 10 months ago

@funkemunky please note that you effectively removed my fix for the null suggestions, because you chose to revert whilst also applying the fix for the build issue.

Can you please cherry-pick the commit again, or revert the revert of #35 ?

This pr without #35 does exactly nothing.