funkemunky / Kauri

GNU Affero General Public License v3.0
86 stars 24 forks source link

False Flag a couple of things when using elytra #33

Open Chanakan5591 opened 2 years ago

Chanakan5591 commented 2 years ago

Kauri seem to false flag multiple checks when using elytra, here is a video showing it.

https://user-images.githubusercontent.com/80865605/169515781-5c8d1139-b169-49e4-a723-aaaf11120a8d.mp4

funkemunky commented 2 years ago

Ah I see it's when the elytra state is toggled. I will put in a fix for this real quick. Unfortunately, there's no good way to check if a player is gliding on the server side as the player will only send when they start gliding, not when they stop. In Bedrock, both are sent. So basically, I will pretty much have to always check if they have an elytra equipped. I can probably limit it to only when they are near ground and equipped, but it's a necessary compromise for stability.

funkemunky commented 2 years ago

I pushed a change in ed69a11deabf68e8db3f2ad654233940a67cab05. If you can try this again using your test conditions by using the artifact (Detections-2.18.3.jar) generated here, that would be amazing!

Chanakan5591 commented 2 years ago

hello!, I've tried again with that artifact and it still seem to false flag with the same check 2022-06-01_06 21 50