Ping is always 0 if a player is not on 1.17.1 (1.17.1 server)

Nidocraft commented 2 years ago

Basically, Kauri doesn't seem to properly detect ping on 1.17.1. No players ever seem to get above 0 ping, unless the player is on 1.17.1. A player gets up to some amount of ping, but it's never even close to their actual ping. If this issue is a bug, I can imagine it would impact the detections quite severely.

I've initially come across this on a production instance of us and I then proceeded to use a very new build and a standalone Pufferfish server to check if the issue was still there. It turns out; the issue does not disappear. I've included screenshots on where I saw the ping being incorrect.

My ping to the test server according to Kauri:

This is my actual ping to the test server:

Important notes:

We do use TCPShield, if that matters anyhow.
Both tests were on 1.17
We run an older build on our network, but the Kauri version on the temporary test server is commit ac2961992cd9ea1e519b86b9500df11642697a89.

This is actually my first ever GitHub issue, so if there's anything missing I'd love to add more details.

Aseeef commented 2 years ago

Werent transaction packets removed after 1.17? @funkemunky?

Aseeef commented 2 years ago

Nvm but the packet structure is different now assuming I got the right packet. https://wiki.vg/Protocol#Ping_.28play.29

funkemunky commented 2 years ago

The ping is in ticks, this is normal. 0 is actually the correct output.

funkemunky / Kauri

Ping is always 0 if a player is not on 1.17.1 (1.17.1 server) #62