The addon provides a storageFor computed property that returns a proxy and persists the changes to localStorage or sessionStorage. It ships with an ember-data adapter.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of ember-ajax.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
After much discussion, the team around ember-ajax decided that it was probably not a great idea to reformat the error payload to match some arbitrary format that we designed. Instead, we should just use the payload that the server returned.
If you want to maintain the old behavior, you can include the the legacy/normalize-error-response mixin, which has the old version of the method included and will override the new behavior.
// app/services/ajax.jsimportAjaxServicefrom'ember-ajax/services/ajax';
importLegacyNormalizeErrorResponsefrom'ember-ajax/mixins/legacy/normalize-error-response';
exportdefaultAjaxService.extends(LegacyNormalizeErrorResponse, {
// Your other configuration here
});
Replacing AjaxError.errors with AjaxError.payload
The errors property on any AjaxError subclass has been deprecated in favor of a payload property for a while now. If you want access to the response from the server, you should now use the payload property, like so:
returnthis.get('ajax').request('/posts')
.then((posts) => {
// Do something with your posts
})
.catch((error) => {
this.displayError(error.payload); // `error.payload` will be whatever the server responded with
});
No longer modify null or undefined server response (#232)
If your server response is interpreted by jQuery#ajax to be null or undefined, we will resolve that value, instead of turning it into an empty object.
The new version differs by 49 commits (ahead by 49, behind by 7).
With Integrationsfirst-class bot support landed on GitHub and we’ve rewritten Greenkeeper to take full advantage of it. Simpler setup, fewer pull-requests, faster than ever.
Screencast Try it today. Free for private repositories during beta.
Hello lovely humans,
ember-ajax just published its new version 3.0.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of ember-ajax. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right? Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project :sparkles:
You rock!
:palm_tree:
GitHub Release
Breaking Changes
Simplifying
normalizeErrorResponseAfter much discussion, the team around
ember-ajaxdecided that it was probably not a great idea to reformat the error payload to match some arbitrary format that we designed. Instead, we should just use the payload that the server returned.If you want to maintain the old behavior, you can include the the
legacy/normalize-error-responsemixin, which has the old version of the method included and will override the new behavior.Replacing
AjaxError.errorswithAjaxError.payloadThe
errorsproperty on anyAjaxErrorsubclass has been deprecated in favor of apayloadproperty for a while now. If you want access to the response from the server, you should now use thepayloadproperty, like so:No longer modify null or undefined server response (#232)
If your server response is interpreted by jQuery#ajax to be
nullorundefined, we will resolve that value, instead of turning it into an empty object.The new version differs by 49 commits (ahead by 49, behind by 7).
2aba19eReleased v3.0.05c6a45aUpgrade dependencies (#283)acd384ffix(package): update ember-cli-babel to version 6.0.0-beta.10 (#277)c70bc9aUpdate to use Babel 6 (#266)528e843Upgradeember-resolverto 4.1.04181656Released v3.0.0-beta.186ab8d0Fix issues with the isString helper723dd66Tighten ESLint config78de692Hide container by default when running testsac023c1Slight cleanup of JSON test helper60cb8demake sure contentType is a string before running a regex match (#250)4e784a2Released v3.0.0-beta.0fe03044Released v2.5.7-beta.0db086b3Released v2.5.71f4ca9dSimplifynormalizeErrorResponse(#265)There are 49 commits in total. See the full diff.
Screencast
Try it today. Free for private repositories during beta.