funkensturm / ember-local-storage

The addon provides a storageFor computed property that returns a proxy and persists the changes to localStorage or sessionStorage. It ships with an ember-data adapter.
https://www.funkensturm.com/ember-local-storage/
MIT License
218 stars 76 forks source link

_resetStorages() Documentation #258

Closed Houndsto0th closed 5 years ago

Houndsto0th commented 7 years ago

We've been wrestling with state bleeding between acceptance tests when one of our engineers came across the _resetStorages() helper that you use in the test suite for the addon itself. I would think this should probably be in the documentation as a way to consistently reset the value of local storage variables in Acceptance tests in a beforeEach() block since other approaches like window.localStorage.clear() don't work.

fsmanuel commented 7 years ago

@Houndsto0th I'm happy to accept a PR that provides a test helper/function that uses _resetStorages() and updates the docs!

fsmanuel commented 5 years ago

Closed via #296