search

funkensturm / ember-local-storage

The addon provides a storageFor computed property that returns a proxy and persists the changes to localStorage or sessionStorage. It ships with an ember-data adapter.
https://www.funkensturm.com/ember-local-storage/
MIT License
218 stars 76 forks source link

Uses ember-copy addon since the Ember.copy is deprecated #287

Closed selvaa89 closed 6 years ago

fsmanuel commented 6 years ago

@selvaa89 thanks for the PR. I’ll review asap.

fsmanuel commented 6 years ago

@selvaa89 thanks for the PR! It would be nice if you add the change from https://github.com/funkensturm/ember-local-storage/pull/290/files#diff-e2c77e724afeb3b1ae1d620269d3b666R58 as well.

I'm working on this PR https://github.com/funkensturm/ember-local-storage/pull/291 to get the tests running. There is a change in ember 3.1. that breaks the addon. I'll let you know when I'm done.

selvaa89 commented 6 years ago

Done.

fsmanuel commented 6 years ago

@selvaa89 I released 1.4.2

selvaa89 commented 6 years ago

Great, thanks

On Tue, 21 Aug 2018 at 2:10 AM, Manuel Wiedenmann notifications@github.com wrote:

@selvaa89 https://github.com/selvaa89 I released 1.4.2

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/funkensturm/ember-local-storage/pull/287#issuecomment-414411125, or mute the thread https://github.com/notifications/unsubscribe-auth/AA1IRNjpKdys97QLv9HdDPViWDruYgA7ks5uSvulgaJpZM4Vl-PB .

-- Regards, Selva