[WIP] Pass all the things. Support 2.12 to 3.3

funkensturm / ember-local-storage

The addon provides a storageFor computed property that returns a proxy and persists the changes to localStorage or sessionStorage. It ships with an ember-data adapter.

https://www.funkensturm.com/ember-local-storage/

MIT License

218 stars 76 forks source link

[WIP] Pass all the things. Support 2.12 to 3.3 #289

Closed tylerturdenpants closed 6 years ago

tylerturdenpants commented 6 years ago

Removed bower. Should support 2.12 to 3.3 when finished.

Brings addon current, including tests.

work to finish:

[ ] fix highlightjs import for dummy example app
[ ] remove "Use of @ember/OrderedSet is deprecated"
[ ] query record test broken

fsmanuel commented 6 years ago

@tylerturdenpants thanks for all the effort! I'm working on this PR https://github.com/funkensturm/ember-local-storage/pull/291 to get the tests running. There is a change in ember 3.1. that breaks the addon. I'll let you know when I'm done so you can rebase.

fsmanuel commented 6 years ago

@tylerturdenpants I merged the build fix. Not sure if a rebase makes sense or if you want to start a new PR for the update. I already solved

fix highlightjs import for dummy example app
query record test broken

If you don't have time I can take over the update just let me know.

tylerturdenpants commented 6 years ago

@fsmanuel, I can take it from here. If I run into anything major, I’ll ping you.