search

funkensturm / ember-local-storage

The addon provides a storageFor computed property that returns a proxy and persists the changes to localStorage or sessionStorage. It ships with an ember-data adapter.
https://www.funkensturm.com/ember-local-storage/
MIT License
218 stars 76 forks source link

Pluralize addon-test-support/reset-storage.js to match with documentation #297

Closed gabz75 closed 5 years ago

gabz75 commented 5 years ago

Hi there.

The documentation refers to this module, but the actual file was singular.

import resetStorages from 'ember-local-storage/test-support/reset-storages';
fsmanuel commented 5 years ago

@gabz75 Good catch! Can you copy the file instead of renaming so we don't break it for people using the singular version? A deprecation message for the singular version would be great if you know how to do it! Otherwise I'll add the deprecation notice.

gabz75 commented 5 years ago

Good idea @fsmanuel, I added back the singular version and the deprecation warning. Let me know if that works for you!

RobbieTheWagner commented 5 years ago

Why don't we just update the docs here to point to the singular version? Seems like overkill to have both.

fsmanuel commented 5 years ago

@rwwagner90 good point! I updated the readme.

/cc @gabz75 anyway thanks for the help!