search

funkensturm / ember-local-storage

The addon provides a storageFor computed property that returns a proxy and persists the changes to localStorage or sessionStorage. It ships with an ember-data adapter.
https://www.funkensturm.com/ember-local-storage/
MIT License
218 stars 76 forks source link

Update All The Things #301

Closed knownasilya closed 5 years ago

knownasilya commented 5 years ago

Ran ember-cli-update and then the codemods. Fixed the test helpers and linting. The dummy app might need some styling fixes after the linting. Will have a look later.

Not sure if this requires a major version bump since the support matrix might have changed a bit.

fsmanuel commented 5 years ago

@knownasilya Thanks! I'll do a review asap. Is there a particular reason why you switched from yarn to npm?

knownasilya commented 5 years ago

For npm audit, since yarn doesn't do that. I can do yarn if you want.

dfreeman commented 5 years ago

Doesn't yarn do that?

knownasilya commented 5 years ago

Oh, didn't know that. Npm does it automatically on install.

fsmanuel commented 5 years ago

Thanks @dfreeman for the hint. @knownasilya I think we should go with yarn.

knownasilya commented 5 years ago

@fsmanuel done

fsmanuel commented 5 years ago

@knownasilya can you also run the blueprints again. All the npm run commands should be replaced by yarn. I'm not 100% sure but if I recall correctly the blueprint should detect yarn and act according to it.

knownasilya commented 5 years ago

@fsmanuel for the travis config?

knownasilya commented 5 years ago

@fsmanuel looks like both 2.12 and 2.16 fail.

fsmanuel commented 5 years ago

@knownasilya not sure how to make ember-data work for the release channels but I asked here: https://github.com/ember-cli/ember-source-channel-url/issues/5#issuecomment-454144428

knownasilya commented 5 years ago

Ping @fsmanuel

fsmanuel commented 5 years ago

@knownasilya seems like we need jquery for lts-2.16 and lts-2.12 needs ember-cli-shims. Here is how we can setup the right ember-data versions for the release channels: https://github.com/ember-cli/ember-source-channel-url/issues/5#issuecomment-454312491

fsmanuel commented 5 years ago

@knownasilya do you need more help or suggestions?

knownasilya commented 5 years ago

Just haven't had time to dig back into this. I'll try to look at it this week.

fsmanuel commented 5 years ago

@knownasilya No rush!

fsmanuel commented 5 years ago

Hey @knownasilya, thanks for all the work! I took over your branch here #311 and fixed the nasty ember try config. I'll ping you as soon as I release a new version.

knownasilya commented 5 years ago

Nice, great work!