search

funkensturm / ember-local-storage

The addon provides a storageFor computed property that returns a proxy and persists the changes to localStorage or sessionStorage. It ships with an ember-data adapter.
https://www.funkensturm.com/ember-local-storage/
MIT License
218 stars 76 forks source link

ember-data support removed when used by ember-twiddle #302

Closed sukima closed 5 years ago

sukima commented 5 years ago

The addon removes all the ember-data support modules which makes sense for projects that do not have ember-data as a dependency.

Unfortunately the checking logic depends on a package.json which does not exist in an ember-twiddle project.

I would like to suggest that there be a config option to disable the pruning logic that way in a twiddle the following twiddle.json can enable the ember-data support:

{
  "version": "0.15.1",
  "EmberENV": {
    "FEATURES": {}
  },
  "ENV": {
    "ember-local-storage": {
      "includeEmberDataSupport": true
    }
  },
  "options": {
    "use_pods": false,
    "enable-testing": false
  },
  "dependencies": {
    "jquery": "https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.js",
    "ember": "3.4.3",
    "ember-template-compiler": "3.4.3",
    "ember-testing": "3.4.3"
  },
  "addons": {
    "ember-data": "3.4.2",
    "ember-local-storage": "1.5.0"
  }
}
fsmanuel commented 5 years ago

@sukima Released as 1.6.0