search

funkensturm / ember-local-storage

The addon provides a storageFor computed property that returns a proxy and persists the changes to localStorage or sessionStorage. It ships with an ember-data adapter.
https://www.funkensturm.com/ember-local-storage/
MIT License
218 stars 76 forks source link

Ember 3.4.4 Models Not Setting On Browser Reload #309

Closed jrock2004 closed 2 years ago

jrock2004 commented 5 years ago

Been using this add-on for awhile and I have encountered an issue during an ember and addon upgrade that I need some help with. On an adapter for a model I have set the following

export { default } from 'ember-local-storage/adapters/local';

Looking at local storage I seem the model and I see the relationship just fine

image

Everything is working until I reload the page. Before the upgrade the models would load just fine. But now the models load but values are missing. Its not being removed from local storage as I see it. Not sure what additional info you may need for this. It seems like the model types are all of the sudden unknown

image

Update 1:

So I went back to ember 2.18 and kept newest version of ember local storage and it works. I upgraded ember data version by version and found that what broke reloading is 3.2.2. Going to try to get a couple of twiddles with examples

image

fsmanuel commented 5 years ago

@jrock2004 Thanks for reporting! I'll take a look in the next days. The problems were introduced with 3.4, right?

jrock2004 commented 5 years ago

@fsmanuel not sure if it was exactly 3.4 it started.

jrock2004 commented 5 years ago

Seems like ember-data 3.2.2 is where the issue began

fsmanuel commented 5 years ago

@jrock2004 could you solve the problem?

fsmanuel commented 2 years ago

Because of inactivity I'm closing this. Feel free to reopen.