Is this addon expected to work with Ember Octane?

[jking6884]

I am seeing an issue with getting this addon to work with Ember 3.26, but it was previously working in 3.11.

[fsmanuel]

@jking6884 It's supposed to work. I'm using it with 3.24.0. What are the issues?

[jking6884]

There seems to be a couple of problems, I think.

This computed that is returned from storageFor never seems to fire the way it is set up. I was thinking this was potentially because of the fact that the get/set functionality is not the same in the native classes in Octane. At any rate, it doesn't seem to fire ever, so the storage create method isn't called either. However, I also found that if I tweaked the way that the logic worked (I create an in-repo-addon with ember-local-storge and changed things to test), the create method was also not getting the proper value of this. So I had to pass in the context from the controller when calling storageFor.

The computed property also doesn't seem to be firing when setting values.

[fsmanuel]

You can use it like that:

import { storageFor } from "ember-local-storage";

export default class extends Controller {
  @storageFor('role') roleStorage;

  doSomething() {
    this.roleStorage.get('someKey');
  }
}

[jking6884]

@fsmanuel I have confirmed that it is indeed working when using it as a decorator. Thanks for that clarification.

I think it would be a great idea to document this in the readme as it is currently not very clear how this addon should be used in the context of native classes with Octane.

[fsmanuel]

@jking6884 good point. Will add documentation for native classes in the next days.