search

funkensturm / ember-local-storage

The addon provides a storageFor computed property that returns a proxy and persists the changes to localStorage or sessionStorage. It ships with an ember-data adapter.
https://www.funkensturm.com/ember-local-storage/
MIT License
218 stars 76 forks source link

Ember 4 compatibility #340

Closed pago closed 2 years ago

pago commented 2 years ago

We are in the process of trying to upgrade our Ember application to v4. After upgrading, running the application fails due to ember-local-storage importing deprecate from @ember/application/deprecations in addon/helpers/storage.js, which does not exist.

This issue has already been fixed in this PR: https://github.com/funkensturm/ember-local-storage/pull/339/files However, the currently released v2.0.0 of this addon seems to not include that change.

My assumption would be that the issue could be fixed by releasing the current master branch.

fsmanuel commented 2 years ago

Hey @pago, thanks for reporting. I'll release a new version with the deprecation fix.

fsmanuel commented 2 years ago

@pago v2.0.1 is released. Please let me know if you run into any other problems.

pago commented 2 years ago

Thank you for the fast resolution. Works like a charm! We've been able to upgrade our app to Ember 4.

fsmanuel commented 2 years ago

Great!