Guard against missing window.navigator to allow fastboot

funkensturm / ember-local-storage

The addon provides a storageFor computed property that returns a proxy and persists the changes to localStorage or sessionStorage. It ships with an ember-data adapter.

https://www.funkensturm.com/ember-local-storage/

MIT License

218 stars 76 forks source link

Guard against missing window.navigator to allow fastboot #341

Closed fsmanuel closed 2 years ago

fsmanuel commented 2 years ago

@vlascik can you check if the changes in this branch fix-fastboot solve the problem?

vlascik commented 2 years ago

Should be fine for fixing the boot issue, I temporarily worked around it the same way, but making the local storage work for real would require polyfilling the missing node APIs. Whether that's necessary remains to be seen, but I guess for now it's ok just to make it boot.

Thank you.