search

funkensturm / ember-local-storage

The addon provides a storageFor computed property that returns a proxy and persists the changes to localStorage or sessionStorage. It ships with an ember-data adapter.
https://www.funkensturm.com/ember-local-storage/
MIT License
218 stars 76 forks source link

Remove non-existent keys polyfill #375

Closed stevensona closed 1 year ago

stevensona commented 1 year ago

@ember/polyfills has never included a polyfill for Object.keys, to my knowledge. import fails.

https://github.com/emberjs/ember.js/blob/v4.4.0/packages/%40ember/polyfills/index.ts

fsmanuel commented 1 year ago

@stevensona thanks for the PR!

Interesting that it became an error now. Which version of ember are you using? The changes came in via a codemod: https://github.com/funkensturm/ember-local-storage/commit/0d412bd503479cd4570e7421b5bf0cffb29afd51 but surely we should use Object.keys.

stevensona commented 1 year ago

@stevensona thanks for the PR!

Interesting that it became an error now. Which version of ember are you using? The changes came in via a codemod: 0d412bd but surely we should use Object.keys.

Error on latest ember (5.1) when importing the adapter.

fsmanuel commented 1 year ago

@stevensona thanks again. I released v2.0.6