PeerDependency `@ember/string` is missing

funkensturm / ember-local-storage

The addon provides a storageFor computed property that returns a proxy and persists the changes to localStorage or sessionStorage. It ships with an ember-data adapter.

https://www.funkensturm.com/ember-local-storage/

MIT License

218 stars 76 forks source link

PeerDependency `@ember/string` is missing #380

Open mkszepp opened 2 months ago

mkszepp commented 2 months ago

The addon is using @ember/string but its not declared as peerDependency.

This makes impossible to use @ember/string v4 as its a v2 addon

https://github.com/funkensturm/ember-local-storage/blob/02112d14e475520a776f3eb97ef4bf918e10fd79/addon/helpers/storage.js#L1-L8

There are two options to fix this issue:

adding dasherize as internal function (not braking - recommended)
adding @ember/string as peerDependency (braking)