search

funkey / recept

Pen event interception for line smoothing on the reMarkable 2 tablet
MIT License
163 stars 13 forks source link

Add reMarkable 1 support #14

Open Eeems opened 1 year ago

Eeems commented 1 year ago

I removed the precompiled binaries since it's not really best practice to include them in the source. Instead I'd recommend uploading a zip containing them and install.sh to a release tag.

Eeems commented 1 year ago

Fixes #13

Eeems commented 1 year ago

@funkey is there anything you'd like me to change before merging?

funkey commented 1 year ago

Hi Nathaniel,

Thanks a lot for the PR. Adding RM1 support is great, happy to include that.

However, I don't want to remove the precompiled binaries. The reason I include them along the source is that not every user of recept might be able (or willing) to compile the code themselves. This will pose a barrier for most users.

So I suggest you either keep the precompiled binaries (they are tiny) or add a script to download them as you suggested. I'd very much prefer the former.

Eeems commented 1 year ago

Let me clarify, I wasn't suggesting a script to download them, I was suggesting adding an artifact to a release tag that users can download that contains the existing install.sh script, as well as the precompiled binaries.

I wouldn't mind taking some time to automate this with github actions if you'd like.

funkey commented 1 year ago

I see. Sure, go ahead then, sounds good to me!

Eeems commented 1 year ago

Sorry for how long this took. I had some stuff come up. I've only automated the build here, but you should be able to automate creating a new version on merge to master, and attaching the build artifacts.

Eeems commented 1 year ago

Example run since you have to allow my pull request to run this: https://github.com/Eeems/recept/actions/runs/4887019353

Eeems commented 9 months ago

@funkey poke?

Eeems commented 8 months ago

@funkey poke again?