🐛 Add missing undefinded variable input

funkhaus / wp-graphql-cors

Makes WP GraphQL's authetication "just work". It does this by customizing the CORS headers.

GNU General Public License v3.0

112 stars 21 forks source link

🐛 Add missing undefinded variable input #13

Closed jacobarriola closed 4 years ago

jacobarriola commented 4 years ago

When running the loginWithCookies mutation, the server errors out and doesn't return an expected value. Looking at my Sentry report, it looks as though there's a missing variable.

Specifically, the mutateAndGetPayload is missing the $input variable in its callback function. As a result, the subsequent foreach is throwing an ErrorException for an invalid argument.

Sentry report: https://sentry.io/share/issue/bb2aaa28f07a4c48bc917ee51a9f05b8/

jacobarriola commented 4 years ago

Hey @kidunot89 👋 . Not sure if you're the point person to review this PR, but it would be great to get a set of eyes 👀 on it if you have some time.

It's not a blocker for me atm; I went ahead and forked this so that the loginWithCookies mutation works for my project.

Thanks!

drewbaker commented 4 years ago

I fixed this interdependently because of your other PR that worked on the error message with this same function. Can you tell we don't use the login function at Funkhaus?! LOL!