search

funkjedi / acf-qtranslate

Adds qTranslate compatible fields for Text, Text Area, Wysiwyg Editor and Image.
http://wordpress.org/plugins/acf-qtranslate/
57 stars 32 forks source link

Media Library Not Loading in Grid View #135

Open jisanpolara opened 4 years ago

jisanpolara commented 4 years ago

The acf-qtranslate plugin is conflicting with media library, If I will disable plugin then media library is working fine.

bernester commented 4 years ago

same problem here. unfortunately i can not disable the plugin this easaly. terminal prompts the following error Uncaught TypeError: Cannot read property 'prototype' of undefined at qtranslatex.js?ver=5.2.2:95 at dispatch (load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:3) at r.handle (load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:3) (anonymous) @ qtranslatex.js?ver=5.2.2:95 dispatch @ load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:3 r.handle @ load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:3 load (async) add @ load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:3 a.event.add @ load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:8 (anonymous) @ load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:3 each @ load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:2 each @ load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:2 ra @ load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:3 on @ load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:3 (anonymous) @ acf-input.min.js?ver=5.8.3:1 (anonymous) @ acf-input.min.js?ver=5.8.3:1

bichonnages commented 4 years ago

Same thing here.

pszurgot commented 4 years ago

Use ACF 5.8.2 or use qTranslate-XT (it works with acf 5.8.3 and this plugin).

https://support.advancedcustomfields.com/forums/topic/media-library-broken-after-update-to-acf-5-8-3-with-acf-qtranslate/

jisanpolara commented 4 years ago

Hi,

This plugin is working fine now. Wow. https://github.com/qtranslate/qtranslate-xt

NorioTakenaga commented 4 years ago

Same issue on my project with ACF 5.8.3.

I commented out a hook on line 75 in acf-qtranslate/src/acf_5/fields/image.php. Then media library works well. If anyone want to try, please comment out or remove this line in acf-qtranslate/src/acf_5/fields/image.php.

add_filter('wp_prepare_attachment_for_js',array($this, 'wp_prepare_attachment_for_js'), 10, 3);

or, should change the code like this

    if (method_exists($this, 'wp_prepare_attachment_for_js')) {
            add_filter('wp_prepare_attachment_for_js', array($this, 'wp_prepare_attachment_for_js'), 10, 3);
    }

acf_qtranslate_acf_5_image class in this file must be an inheritance of acf_field_image class in advanced-custom-fields-pro/includes/fields/class-acf-field-image.php.

But it seems that in ACF 5.8.3, a function (wp_prepare_attachment_for_js) has been removed from the file and a hook using that function is removed too. It seems that this function has been moved to line 165 in advanced-custom-fields-pro/includes/media.php. So I think this caused the issue.

I still wonder whether this would be a right solution or not, so I hope somoene will try this.

sherlockmac commented 4 years ago

I can confirm this works with ACF PRO 5.8.4

acf-qtranslate/src/acf_5/fields/image.php

if (method_exists($this, 'wp_prepare_attachment_for_js')) { 
    add_filter('wp_prepare_attachment_for_js', array($this, 'wp_prepare_attachment_for_js'), 10, 3);
}
jlavnv commented 4 years ago

thanks @sherlockmac I was very headache with this problem, thank you for sharing