search

funksft / mobbler

Automatically exported from code.google.com/p/mobbler
0 stars 0 forks source link

Artist biography / info screen #109

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Version 0.3 is awesome, up until now no bugs, and all the new look is
great. As it has been suggested, the only big feature that remains to be
integrated is the proper fetching of album/band info (like the pc client). 

Since in this case the client gets potentially large amount of text, I
think Mobbler's UI should be extended with a new screen that displays Band
info with text in smaller font size, and is scrollable. The user could
switch between this and the normal 'player' screen with the right softkey
(that is, Mobbler could be only closed/hidden with trough the leftkey-menu
- but I think the sacrifice is worth it). What do you think of this idea?

Original issue reported on code.google.com by poisonborz on 19 Oct 2008 at 1:30

GoogleCodeExporter commented 8 years ago 
Yes.  I think that this will be one of the next features to be added to 
Mobbler.  I'm
not really sure how it will work at the UI side yet, but I will keep your ideas 
in mind.

Cheers!

Original comment by eartle@gmail.com on 19 Oct 2008 at 1:35

GoogleCodeExporter commented 8 years ago 
Issue 351 has been merged into this issue.

Original comment by hugovk@gmail.com on 7 Apr 2009 at 8:41

GoogleCodeExporter commented 8 years ago

Original comment by hugovk@gmail.com on 7 Apr 2009 at 8:41

GoogleCodeExporter commented 8 years ago 
You can see the artist info/biog by 
pressing the zero key, and it will load 
the m.last.fm page in an embedded 
browser.

But we should still implement a 
"proper" method.

Original comment by hugovk@gmail.com on 21 Jun 2009 at 6:44

GoogleCodeExporter commented 8 years ago 
How about fitting it in as an additional option in the UI in the "+" menu 
(trigger by
left on the main screen)?

Original comment by gw111zz@gmail.com on 25 Jun 2009 at 8:53

GoogleCodeExporter commented 8 years ago 
Yes, the zero key stuff can also be seen in the + menu, it's in the latest 
trunk but 
didn't make the last 0.6(5124) release. It's issue 397. 

We should still do a real biography thing, and download and display the data in 
a 
view in Mobbler. Feel free to have a go at implementing this if you want ! :) 
We can 
discuss any ideas here.

Original comment by hugovk@gmail.com on 25 Jun 2009 at 9:02

GoogleCodeExporter commented 8 years ago

Original comment by gw111zz@gmail.com on 27 Jun 2009 at 2:38

GoogleCodeExporter commented 8 years ago 
I've done the basic functionality. Right now the + menu contains an option 
which lets
the user view the artist's biography which pops up (see screenshot attached)

Original comment by gw111zz@gmail.com on 29 Jun 2009 at 9:00

Attachments:

GoogleCodeExporter commented 8 years ago 
Nice.  I was hoping that this would replace the option to open m.last.fm, but 
I'm not
really sure how best to do it.  It also seems like a lot of work.

Original comment by eartle@gmail.com on 29 Jun 2009 at 9:55

GoogleCodeExporter commented 8 years ago 
It'd be really cool to have a new view for biog stuff, with the photo as well 
(and 
maybe even tags and similar artist stuff).

Original comment by hugovk@gmail.com on 30 Jun 2009 at 4:19

GoogleCodeExporter commented 8 years ago 
Yes, a new view for the bio would be good, the iPhone version has this. Right 
now my
screen shot just shows the "Summary" of the artist's biography but more 
information
can be retrieved. 

I've already been looking at the richtext view for display, however, the text 
sent
back from Last.fm is littered with HTML and IIRC some BBCode as the biography 
is a
wiki so converting the information to be displayed into RichText won't be 
trivial.

hugovk, eartle: Are you aware of any S60 HTML parsing / tag stripping APIs?

Original comment by gw111zz@gmail.com on 1 Jul 2009 at 8:41

GoogleCodeExporter commented 8 years ago 
Yes.  That is one of the main reasons I've ignored this.  Symbian has a HTML to 
rich
text converter, but it doesn't seem to be included on S60.  There are some 
helpers in
the S60 web services stuff to convert those & " things to & and ", but I don't
know of anything more helpful than that.

Original comment by eartle@gmail.com on 1 Jul 2009 at 9:43

GoogleCodeExporter commented 8 years ago 
Thanks Eartle. I'll take a look at what's available in the S60 web services 
APIs.
Last.fm returns many symbols as entities but as the bio text is inputted by 
users via
a wiki, there could be a limited number of tags that actually get returned. 
I'll take
a look.

Original comment by gw111zz@gmail.com on 2 Jul 2009 at 7:47

GoogleCodeExporter commented 8 years ago

Original comment by gw111zz@gmail.com on 27 Jul 2009 at 6:17

GoogleCodeExporter commented 8 years ago 
Hello! Just to let you know that we are now using a mercurial repository so all 
new changes should be 
submitted there. Let me know if you help getting set up.

Original comment by eartle@gmail.com on 27 Jul 2009 at 6:47

GoogleCodeExporter commented 8 years ago 
Thanks Eartle. Will our change history on trunk and our personal branches still 
be
visible?

Original comment by gw111zz@gmail.com on 27 Jul 2009 at 6:49

GoogleCodeExporter commented 8 years ago 
The svn repository is still there so we should have all the history. I think we 
have lost comments on 
revisions, but I may be able bacl if desperately needed.

Original comment by eartle@gmail.com on 27 Jul 2009 at 7:42

GoogleCodeExporter commented 8 years ago 
Do you use TortoiseHg to access Mercurial?

Original comment by hugovk@gmail.com on 29 Jul 2009 at 10:31

GoogleCodeExporter commented 8 years ago 
TortoiseHg doesn't seem to be as mature as TortoiseSVN so in some ways this is 
a step
back, but it isn't too bad.  I have so far used a combination of TortoiseHg and 
the
command line, but I'm hoping to just use TortoiseHg.

Original comment by eartle@gmail.com on 29 Jul 2009 at 12:22

GoogleCodeExporter commented 8 years ago 
Eartle, Hugovk,

Do either of you know how to detect if the app is running on 3rd edition or 3rd
edition FP1?

Original comment by gw111zz@gmail.com on 20 Aug 2009 at 10:11

GoogleCodeExporter commented 8 years ago 
Ideally you could just check the Platform ID, but I don't think you can get 
that at 
runtime. 

Otherwise you can get the Product ID using HAL::Get() and compare it against a 
list 
of hardcoded UIDs. 

Finally, you could check for presence or absence of stub sis files like 
z:\system
\install\Series60v3.0.sis. "Note that S60 3rd FP1 devices have both 
series60v3.0.sis 
and series60v3.1.sis. Furthermore, S60 3rd FP2 devices have series60v3.0.sis, 
series60v3.1.sis and series60v3.2.sis." See 1.6 "Checking File Existence" in:
http://developer.symbian.com/wiki/download/attachments/1920/
Some_Tricks_for_Writing_PKG_File.doc?version=2

Check these lists:
https://developer.symbian.com/wiki/display/pub/Device+vs+Product,+Platform,+HAL
+information
http://www.newlc.com/en/Common-products-UIDs.html

=

Why do you want to tell the difference between 3.0 and 3.1?

Original comment by hugovk@gmail.com on 22 Aug 2009 at 12:06

GoogleCodeExporter commented 8 years ago 
Thanks for the hints hugovk, I'll take a look at them.

I'm trying to use the Browser Control to display the artist info. but due to 
this
issue
http://wiki.forum.nokia.com/index.php/KIS001002_-_Change_in_creation_of_BrowserC
ontrol_instance_for_S60_3rd_Edition_and_S60_3rd_Edition%2C_FP1

the instance is created with different parameters depending on whether the 
version is
3.0 or 3.1. I've only got a 3.1 device so I haven't seen what the effects are of
using the 3.1 instantiation method on a 3.0 device but I've seen that the S60 
example
app demonstrating this control (which wasn't updated for 3.1) doesn't draw the
control in the correct part of the screen.

Original comment by gw111zz@gmail.com on 22 Aug 2009 at 5:49

GoogleCodeExporter commented 8 years ago 
Here's how it's looking on my third edition phone.

Still need to address Comment 9 about it replacing the "Visit Last.fm" 
functionality
but that's fairly trivial and I need to borrow a 5th edition phone to try this.

Original comment by gw111zz@gmail.com on 24 Jan 2010 at 2:12

Attachments:

GoogleCodeExporter commented 8 years ago 
Looks good!

Perhaps we don't need to replace the Visit Last.fm -> [artist] bit as perhaps 
someone might want to be able click the links on the real webpage or something. 
And 
we should keep the Visit Last.fm -> [other stuff].

Also, I think the menu option should be "Biography" rather than "Artist 
biography", 
as it should be obvious it's for the artist and I can foresee translations of 
the 
other text getting too long.

Where should the menu option be in the menu? I think the general idea was to 
try and 
list similar things together, so track stuff comes first, then album stuff, 
then 
artist stuff.

==

Here's some nice-to-haves:

It would be nice to get the paragraph breaks in there if possible, I just 
checked 
the Johnny Cash biography and it goes on for pages and pages. 

It's a bit annoying it asks for the access point again to get the artist image 
from 
within the browser control, but I doubt there's anything we can do about that. 
One 
thing we could do, it check if the image is already Mobbler's artist image 
cache (or 
the mp3's folder), and if so, link to that local image instead. This would have 
been 
useful for a track I was just playing.

Original comment by hugovk@gmail.com on 24 Jan 2010 at 7:52

GoogleCodeExporter commented 8 years ago 
... And for biographies where we don't have the image already cached, Mobbler 
could 
download it to a *temporary* cache and delete it afterwards.

Original comment by hugovk@gmail.com on 24 Jan 2010 at 8:19

GoogleCodeExporter commented 8 years ago 
> Perhaps we don't need to replace the Visit Last.fm -> [artist] bit 

Yes, good point. I'll leave it as it is.

> Also, I think the menu option should be "Biography" rather than "Artist 
biography",
as it should be obvious it's for the artist and I can foresee translations of 
the
other text getting too long.

I've switched it to using the existing STR_mobbler_biography 
However, it's translated as "Bio", I think it sounds better to use the full work
"Biography" as it is a top level menu item on the plus menu. Any objections to
changing it (obviously it'll change in the other place this string is used).

>Where should the menu option be in the menu? I think the general idea was to 
try and 
list similar things together, so track stuff comes first, then album stuff, 
then 
artist stuff.

How about in between "lyrics" and "similar" and move the artist shoutbox up so 
that
artist stuff is together. So:

lyrics
biography
artist shoutbox
similar
top
events

> It would be nice to get the paragraph breaks in there if possible

Shouldn't be too hard to do. I'll take a look.

>It's a bit annoying it asks for the access point again to get the artist image 
from 
>within the browser control

Yes, that is coming from the browser control itself so I don't I can do anything
about it. I don't think it happens on all phones though. I think 5th edition 
phones
have the concept of "destinations" and it knows to pick an Internet access 
point by
itself.

> One 
thing we could do, it check if the image is already Mobbler's artist image cache

I originally wanted to do that but the browser control API is not very 
versatile and
I can't see how to get it to pull in something that isn't from HTTP after I have
given it the input HTML to display.

Original comment by gw111zz@gmail.com on 30 Jan 2010 at 6:45

GoogleCodeExporter commented 8 years ago 
> I've switched it to using the existing STR_mobbler_biography 
However, it's translated as "Bio", I think it sounds better to use the full work
"Biography" as it is a top level menu item on the plus menu. Any objections to
changing it (obviously it'll change in the other place this string is used).

No objections. I think "Biography" is better than "Bio" too. This string isn't 
actually used yet, it was put in the translations for future use, so it's 
already 
been translated: about half have a short "Bio", the other half have a longer 
form. I 
don't see this as a problem.

=

> How about in between "lyrics" and "similar" and move the artist shoutbox up 
so that
artist stuff is together. 

We could even keep the events close by, maybe:

lyrics
biography
events
artist shoutbox
similar
top

Let's check this with eartle when he gets back from hacking music in Stockholm, 
because perhaps the Share/Tag/Similar/Top submenus should be close together.

=

> I originally wanted to do that but the browser control API is not very 
versatile 
and I can't see how to get it to pull in something that isn't from HTTP after I 
have
given it the input HTML to display.

So does it not work with something like <img 
src=file://localhost/C:/System/Data/
Mobbler/biog.jpg> in the input HTML?

Original comment by hugovk@gmail.com on 30 Jan 2010 at 7:07

GoogleCodeExporter commented 8 years ago 
> So does it not work with something like <img 
src=file://localhost/C:/System/Data/
Mobbler/biog.jpg> in the input HTML?

I tried this with a hard-coded file path but just get an "unfound" image icon.

From what I can see in the header file of the browser control, it can accept an 
HTML
file on the file system as the input HTML or it accepts an HTTP URL.

Original comment by gw111zz@gmail.com on 6 Feb 2010 at 7:23

GoogleCodeExporter commented 8 years ago 
Does this help? Seems there's a strange bug in there, and it depends on the 
image 
DPI. There's a suggested workaround in comment #4.

http://discussion.forum.nokia.com/forum/showthread.php?t=185775

They also use a simple path: <img src="logo.png"/>

Original comment by hugovk@gmail.com on 6 Feb 2010 at 7:31

GoogleCodeExporter commented 8 years ago 
> http://discussion.forum.nokia.com/forum/showthread.php?t=185775

I've tried a few experiments: adding a width and height to the image tag, 
changing
the slashes in the path to forward or back slashes.

> They also use a simple path: <img src="logo.png"/>

I don't think that would work for me, no reference path is specified anywhere. 
The
HTML is never written to a file. I take the XML from the Last.fm web service, 
tidy it
and arrange it for display and give the browser control the data in a 
descriptor.

The image embedded in the CSS also isn't displaying.

If you have any other ideas I can give it a go.

Original comment by gw111zz@gmail.com on 6 Feb 2010 at 8:18

GoogleCodeExporter commented 8 years ago 
Perhaps saving the HTML to a temporary file and giving that to browser control 
will 
work. If not, let's not worry about it too much.

Original comment by hugovk@gmail.com on 6 Feb 2010 at 8:32

GoogleCodeExporter commented 8 years ago 
It's ok I've figured out how to make it use the existing connection now.

The browser control's APIs are very strange!

Original comment by gw111zz@gmail.com on 7 Feb 2010 at 5:11

GoogleCodeExporter commented 8 years ago 
Committed into multiple revisions:

71bbb01253
a7a750a1ef
570b35e4a4
045e95a6df
cfaa2b3d86
0df7227cb7
0973cf7c32
5ebcd916e6
879034d9bd
30a1deb256
1099ca85be
ca60bf8bb6
1b0b82e878
1f185f818e
5981a2c61c
8447b6a875
5b0e3915ad
9a4c6a6482
ad800de6d4
2a5b96c798
6e4b59e253
73abae0bdd
8a37abb2bc
52765b4de6
5210eed14c
44544cfe67

Original comment by gw111zz@gmail.com on 7 Feb 2010 at 8:12

GoogleCodeExporter commented 8 years ago 
The biography is looking great, I'll put this as fixed. Good work!

This was the second oldest open report :)

Original comment by hugovk@gmail.com on 24 Feb 2010 at 8:21

GoogleCodeExporter commented 8 years ago 
I realised the biography was only hooked up to the current track, so I've added 
it to the artist list so you can see biographies of artists from search, top 
artists, recommended artists etc. 

Revision 8818df573a

Original comment by hugovk@gmail.com on 13 Nov 2010 at 7:10