funksft / mobbler

Automatically exported from code.google.com/p/mobbler
0 stars 0 forks source link

Music Player name in status pane should be localised #125

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Play music in Music player
2. Check status pane in Mobbler

What is the expected output? What do you see instead?
Actual: "Music Player" in all languages
Expected: The name should match the real localised music player name. For 
example, "Music player" in English (note case), "Soitin" in Finnish.

What version of the product are you using? On what operating system?
* Mobbler 0.3.0 dev
* Nokia N95 8GB v30.0.018 / 23-07-08

Please provide any additional information below.
Is there anyway to look this up using KMusicAppUID?

Original issue reported on code.google.com by hugovk@gmail.com on 21 Oct 2008 at 12:15

GoogleCodeExporter commented 8 years ago
In the meantime, I've changed the case of the hardcoded "Music player", in 
revision 
49 of hugovk branch. A partial fix.

Original comment by hugovk@gmail.com on 22 Oct 2008 at 7:33

GoogleCodeExporter commented 8 years ago
Yes.  This was me being a bit lazy nd then forgetting about it.

I suspect that we can get the name of the music player app using its UID 
through the
API RApaLsSession::GetAppInfo().  The caption in the application info that is
returned should be the name of the music player and should also be localised.

Original comment by eartle@gmail.com on 22 Oct 2008 at 8:10

GoogleCodeExporter commented 8 years ago
Thanks for the pointer, now fixed in r50 of the hugovk branch.

Tested on a N95 8GB: status pane says "Soitin" in Finnish and "Music player" in 
English.

I thought about keeping "Music player" hardcoded in case there was an error 
getting 
the app info, but then decided against it. Feel free to fine tune it :)

Also, I added KMusicAppUID to musicappobserver.cpp as it doesn't share any 
common 
header files with mobblerstatuscontrol.cpp where it was first defined. Should 
it be 
added to some other header file for them both to include? Which one?

Original comment by hugovk@gmail.com on 22 Oct 2008 at 3:07