search

funksft / mobbler

Automatically exported from code.google.com/p/mobbler
0 stars 0 forks source link

RSK should be Hide not Back #93

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Open Mobbler application
2. Look at the right soft key

What is the expected output? What do you see instead?
The right soft key just hides the app, so the text should be "Hide" and 
not "Back". Compare with the built-in S60 Music player and Podcasting 
applications.

What version of the product are you using? On what operating system?
* Mobbler 0.2.4
* Nokia N95 8GB v30.0.018 / 23-07-08

Please provide any additional information below.
The localised langauges should likewise be updated.

Original issue reported on code.google.com by hugovk@gmail.com on 16 Sep 2008 at 3:10

GoogleCodeExporter commented 8 years ago 
Right you are.

I've just had a look and S60 doesn't seem to provide a default for having 
softkeys of
options and hide.  I will have a look into this though as I agree that hide 
would be
a better word for the softkey.

Original comment by eartle@gmail.com on 17 Sep 2008 at 6:30

GoogleCodeExporter commented 8 years ago 
I've fixed this, tested in emulator and on N95 8GB. Please see attached patch, 
based 
upon the latest 0.3.0 dev version. Please check the cba->SetCommandSetL() bit 
is 
called in the right place.  I've added "Options" and "Hide" to the loc files 
using 
Notepad++, hopefully they're ok. I couldn't find localised "Options" and "Hide" 
in 
Avkon, but I wouldn't be suprised if at least "Options" is in there for us to 
use.

Original comment by hugovk@gmail.com on 17 Oct 2008 at 12:15

Attachments:

GoogleCodeExporter commented 8 years ago 
Thanks for this.  However, I'm still not keen on not using default cba buttons. 
Mainly because of the translations as you have identified.

Original comment by eartle@gmail.com on 17 Oct 2008 at 1:10

GoogleCodeExporter commented 8 years ago 
OK, fair enough. Here's another way, it keeps the existing Options softkey, and 
only 
replaces Back with Hide. But Hide must be localised, so again this might not be 
acceptable.

Original comment by hugovk@gmail.com on 20 Oct 2008 at 10:52

Attachments:

GoogleCodeExporter commented 8 years ago 
The thing that annoys me is that 'Hide' is used in several native S60 apps, 
such as
the Music Player.  It must already be there somewhere.  I think that we should
probably go with this solution though.

Cheers!

Original comment by eartle@gmail.com on 20 Oct 2008 at 11:00

GoogleCodeExporter commented 8 years ago 
Fixed in revision 47 in the hugovk branch, using the "take 2" solution.

Original comment by hugovk@gmail.com on 21 Oct 2008 at 8:54