funkster-js / core

Core types and combinators.
https://www.npmjs.com/package/@funkster/core
The Unlicense
1 stars 1 forks source link

An in-range update of sinon is breaking the build 🚨 #15

Closed greenkeeper[bot] closed 7 years ago

greenkeeper[bot] commented 7 years ago

Version 2.3.5 of sinon just got published.

Branch Build failing 🚨
Dependency sinon
Current Version 2.3.4
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As sinon is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this :muscle:

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build failed [Details](https://travis-ci.org/funkster-js/core/builds/244834673?utm_source=github_status&utm_medium=notification)

Release Notes Fix: Check configurable on a prop before creating
  • Check configurable on a prop before creating (fixes #1456) (#1462)
Commits

The new version differs by 8 commits.

  • 33f32ac Update docs/changelog.md and set new release id in docs/_config.yml
  • d00ab2b Add release documentation for v2.3.5
  • 1c690aa 2.3.5
  • cc0a3fb Update Changelog.txt and AUTHORS for new release
  • ef2ecec Check configurable on a prop before creating (fixes #1456) (#1462)
  • e7dbfd7 Merge pull request #1460 from gj/patch-1
  • 512018f Fix minor typos
  • d60d4a2 Fix apostrophe typos (#1454)

See the full diff

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 7 years ago

After pinning to 2.3.4 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.