search

funktionswerk / hapi-i18n

Translation module for hapi based on mashpie's i18n module
MIT License
39 stars 22 forks source link

add options queryParameter and defaultLocale #14

Closed throrin19 closed 7 years ago

throrin19 commented 7 years ago

add the usage of the option queryParameter and defaultLocale after the issue #13

kaywolter commented 7 years ago

Hi @throrin19,

Thank you for your contribution to hapi-i8n. Before I merge the PR into master: Could you please add a test to check the query parameter and extend the README?

Thanks in advance

throrin19 commented 7 years ago

Hi @kaywolter the documentation and test are modify correctly ;)

throrin19 commented 7 years ago

I fix that. It's ok for me. But, in another pull request I made an option to choose if we return 404 or default locale. I think is the best option

throrin19 commented 7 years ago

@kaywolter it's possible to merge that request ? :)