search

funkybob / django-sniplates

Template snippet libraries for Django
MIT License
57 stars 18 forks source link

default widgets set (django.html) is slightly wrong for PasswordInput #57

Closed kezabelle closed 7 years ago

kezabelle commented 7 years ago

Subsequent to 1210d1c45848d89026872dd6ba031a5868797689 (first landing in 0.4.1), it looks like:

{% block PasswordInput %}{% reuse "input" input_type="password" value="" %}{% endblock %}

is wrong I think, value="" ought to be raw_value="" to avoid rendering anything into the input value="" attribute?

sergei-maertens commented 7 years ago

You're right, there is a test for it, but it doesn't test for a widget with value, only empty.