funkydan2 / alpha-church

Hugo theme for churches based on a html5up theme
https://alpha-church.netlify.app
Other
67 stars 58 forks source link

Can i set up the comment below the article? #14

Closed Gan-Jason closed 5 years ago

Gan-Jason commented 5 years ago

Hi,i want to open the commet such like github issue,is it possible?And,can i change the map which show at home page to a static picture in my static folder?

funkydan2 commented 5 years ago

Hi @Gan-Jason, thanks for your questions.

From what I can see you've got two requests:

  1. Implementing a commenting system for blog/podcast, etc.?
  2. An option to replace the map with a picture?

Is that right?

Neither of these are things I've thought about, and I wasn't thinking of implementing them. However,

  1. This is possible. In the hugo docs there's a list of commenting systems which can be implemented. Do you have a preference? (Disqus would be the quickest to implement.)
  2. Would be easy to do—in fact the design I based this theme off has that. It's something I might be able to do in the next few weeks.

Though, if you've got some programming skills, you could fork the project and implement these yourself. And if you wanted to send in a Push Request, I'd be pleased to review the code and include it in the main repo.

Gan-Jason commented 5 years ago

Hi @Gan-Jason, thanks for your questions.

From what I can see you've got two requests:

  1. Implementing a commenting system for blog/podcast, etc.?
  2. An option to replace the map with a picture?

Is that right?

Neither of these are things I've thought about, and I wasn't thinking of implementing them. However,

  1. This is possible. In the hugo docs there's a list of commenting systems which can be implemented. Do you have a preference? (Disqus would be the quickest to implement.)
  2. Would be easy to do—in fact the design I based this theme off has that. It's something I might be able to do in the next few weeks.

Though, if you've got some programming skills, you could fork the project and implement these yourself. And if you wanted to send in a Push Request, I'd be pleased to review the code and include it in the main repo.

Thanks for reply me patiently so much,i figured out these problem with your guide.The second problem that i add a ‘p' label in the index.html to resolve it.I'm sry to bother you again,i deploy my site on my server afterwards,the navigation on the top doesn't work,it cannot be pull down auto or by clicking,such like static text: image is there any configure problem that i've not done yet?

funkydan2 commented 5 years ago

Hi @Gan-Jason,

I found your site's code in your github repository and had a look at it. When I opened up the site in Firefox and looked at the developer tools console, there was a few errors:

Screen Shot 2019-07-27 at 9 26 02 pm

The problem is to do with the SRI resource checking that the theme uses, and so the jquery library isn't being loaded. Is your public server doing any transformation of the assets when it deploys?

Gan-Jason commented 5 years ago

Actually i don‘t know about jQuery,how can i check is the server's transformation? @funkydan2

funkydan2 commented 5 years ago

There's something wonky with the hash-sum encoding for your javascript resources.

Have a look at https://github.com/Gan-Jason/Gan-Blog/blob/36e38fd10b15d0297a2a3b56ada3904545f49d8f/index.html#L283

For some reason the + characters which should be in the SRI checks have been replaced by +.

Gan-Jason commented 5 years ago

There's something wonky with the hash-sum encoding for your javascript resources.

Have a look at https://github.com/Gan-Jason/Gan-Blog/blob/36e38fd10b15d0297a2a3b56ada3904545f49d8f/index.html#L283

For some reason the + characters which should be in the SRI checks have been replaced by +.

It had became replaced by &#43 since i used hugo to build it ,i tried to replace it by myself but it stay the same.

funkydan2 commented 5 years ago

I've not seen characters get encoded that way in the integrity check previously, so I'm wondering where the problem is coming from?

What operating system and version of hugo are you using to build the site (what's the output of hugo version)? How are you uploading/pushing the code to GitHub? How is it deployed to your website?

Gan-Jason commented 5 years ago

Hi,funky.My pc:windows10
hugo:Hugo Static Site Generator v0.55.6/extended windows/amd64
Build command:hugo Then cd into public folder build just now,git add .,git commit...,git push,to push to Github.
In my server:i use the nginx and this is my configure file:
image

Gan-Jason commented 5 years ago

I tried to add a null integrity script behind each script,like this:
image and it did work for some page,but not all page

funkydan2 commented 5 years ago

When you run hugo server does the dropdown menu work? Can you check the page source when running the test server and see if the integrity values are correct?

Gan-Jason commented 5 years ago

When you run hugo server does the dropdown menu work? Can you check the page source when running the test server and see if the integrity values are correct?

yes,it did work in local test,and also the wrong integrity ,i checked it for several times.But there is a surpricing news,it seem to run normally for the reason that i guess is adding those null integrity script

funkydan2 commented 5 years ago

Great - well if it's working don't change anything!

Though I'm still confused as to how the integrity values are being changed. It'd be worth seeing if the values are correct when they're built by hugo (i.e. are they correct in the files in your /public directory, and if not, why not.

Gan-Jason commented 5 years ago

Thanks for your help!The value are not correct in my /public ,Anyway,the theme is fabulous,good job

funkydan2 commented 5 years ago

Great, well I'll close this issue then. If you have any other problems with Hugo, can I recommend the Hugo Discourse Forum. I'm actively involved over there, and there's lots of other great help too.