search

funkydan2 / alpha-church

Hugo theme for churches based on a html5up theme
https://alpha-church.netlify.app
Other
67 stars 58 forks source link

Remove and ignore automatically generated files from example site #16

Closed Anaeijon closed 5 years ago

Anaeijon commented 5 years ago

I've noticed, that you pushed various files, which are automatically generated when running hugo build or hugo serve. I've removed them and added all _gen folders to the .gitignore, to prevent this from happening again.

funkydan2 commented 5 years ago

Thanks @Anaeijon.

Two things

  1. could you clean up this PR as it includes files from your previous PR.
  2. The reason the theme includes files in resources/_gen is because (I think) not everywhere is able to run the extended version of Hugo. When Hugo Pipes was first included, asset processing wasn't available when deploying to Netlify, and I think the Windows version didn't include this feature. For this reason, it was recommended themes include generated assets. I've started a discussion on the Hugo forums as to whether this is still best practice.
funkydan2 commented 5 years ago

Currently hugo themes need to be distributed with the generated resources to be included in the theme directory as the readme says. So we'll close this PR and continue to distrubute the resources.