funkydan2 / alpha-church

Hugo theme for churches based on a html5up theme
https://alpha-church.netlify.app
Other
68 stars 59 forks source link

Remove shortcodes which call partials #21

Closed funkydan2 closed 4 years ago

funkydan2 commented 4 years ago

Since Hugo 0.52.0, there has been an inline shortcodes feature, which is considered a better way to reuse code in partials rather than calling partials from shortcodes.

With the move to the GoldMark renderer in Hugo 0.60.0, shortcodes which call partials are sometimes causing problems (see this thread).

I propose removing the two shortcodes which replicate the functionality of inline shortcodes, for safer operation.

This would mean that instead of calling {{< contact_form >}} to display the contact form partial, you would call {{< contact.inline >}}{{ partial "contact" . }}{{< /contact.inline >}}.

I'll leave this issue open for around one week for discussion, and will commit the changes after that. (This will trigger a new tagged release as it could break sites.)