search

funkydude / BasicMinimap

BasicMinimap is a basic solution to a clean, square minimap for World of Warcraft.
17 stars 10 forks source link

Make class colors work for all classes with the same profile #20

Closed malikoth closed 5 years ago

malikoth commented 5 years ago

With all of the alts that I play, I try to keep my addons configured as generically as possible so that default profiles work for the vast majority of cases. I appreciate that it is technically possible to have class colored border for each class, but that means I have to open the settings and switch profiles and hit the class color button for every alt. On the one hand, that's not such a great burden individually, but it's one more thing I have to do to get my UI back when I log a toon I haven't played in awhile, and this is just one of many addons, all of which are always subtly in flux.

This is all part of my argument for why the I believe profile support is not the ideal solution for this problem.

My proposition is to make it so that clicking the Class Colored button sets the value of map.db.profile.colorBorder to nil (or some other sentinel value). Then in the getter function for colorBorder, if map.db.profile.colorBorder is nil, return the class color of the player.

That way, it is trivial to keep a default profile that works for all toons, and still matches the UI to my class.

funkydude commented 5 years ago

Profiles may not be ideal, but this is not a good implementation, sorry.

malikoth commented 5 years ago

What would a good implementation look like; how would it differ from this one? Is this something I might pursue and eventually see merged in, or is this something you just don't like and don't want (meaning I need not waste my time)?