funkydude / SexyMap

Spice up your minimap in World of Warcraft with some sexy options.
55 stars 9 forks source link

Classic: SexyMap causes green square to appear and not every addon button is customizable in options #73

Closed alecjpav closed 3 years ago

alecjpav commented 5 years ago

SexyMap has this green square in the top right corner around it that I cannot get rid of, except by disabling the addon: WoWScrnShot_082719_091754

Also some addons don't appear in the options so I cannot auto-hide them like I can with the others. The ones that aren't being listed in this screenshot are CTMod, All The Things, Z-Perl, and ClassicCodex, as you can see in the above screenshot they appear even when not hovering your cursor over the minimap: WoWScrnShot_082719_091803

funkydude commented 5 years ago

The "green textures" will happen in pretty much all the default styles. It's because a lot of the textures being used no longer exist in classic, so show as green instead. I will need to extract them from live and package them in the classic zip.

It will take some time and is not top priority compared to fixing bugs. Being abusive about it will just get your comment deleted and/or banned, it will not speed up the process. If anything, it will do the opposite.

In regards to your 2nd point of addons not showing: SexyMap only supports addons using the LibDBIcon library. If an addon decides to go the route of purposely creating their own custom minimap button, that's their choice. But, their button will not show up in SexyMap.

I will not chase after every addon to make sure their buttons show up - it's up to the addon author to take the friendlier approach of using the community library.

This problem is not unique to classic, but most popular addons already use the library.

alecjpav commented 5 years ago

For the green textures, that's good to hear! By live, do you mean the textures are in the live game files or in the live addon version's folder?

As for the minimap buttons, I figured this was the case as I do recall this happening to me in retail too. Is it easier for addon developers to create their own custom minimap or use the library? If it's the former, I'm wondering if many are just temporary placeholders since Classic just launched and will be updated to use the library later on.

Thanks so much for getting back to me I really appreciate it!

funkydude commented 5 years ago

The textures are in the live game and were removed in the classic game. The "green texture" is WoW's placeholder for "this should be a texture but it doesn't exist".

My only solution is to extract the textures from the live game, and bundle them in the zip with SexyMap. It will inflate the zip, but I don't consider that a problem.

It's actually easier for authors to use the library than create their own. I think some just aren't aware it exists.

caniko commented 5 years ago

I think this texture bundle idea is a project of its own for add-on developers. This add-on could certainly benefit from this project. The person who takes that upon himself would have to work many hours to make it accessible for everyone, not sure if it is worth it. Just use other textures instead, a much easier solution. I am sure there textures that look like the one used on sexy map.

I am using the Diablo skin for now, and I must say it has grown on me :P

funkydude commented 5 years ago

I have no interest in a "texture bundle addon". I will bundle only the textures actually being used.

Diablo is a good example of a style that already has bundled textures, since those aren't in the game.

Mazszy commented 5 years ago

download Yes, very sexy... (had to say it)

Jokes aside, can't wait to see this fixed and appreciate the work you're putting in.

Lyeus commented 5 years ago

You guys can fix it by modifying preset and removing the buggy lines (Just do some testings, you can always revert by reselecting preset)

alecjpav commented 5 years ago

You guys can fix it by modifying preset and removing the buggy lines (Just do some testings, you can always revert by reselecting preset)

Thanks for mentioning this. As a temporary fix, deleting Fade gets rid of the green texture with the Blue Rune Circles preset. Looking forward for the textures being added again.

quixadhal commented 5 years ago

I'll mention that the "community" skin of Diablo appears correctly without any artifacts. So until the others are updated, that one is a decent choice and still gives you all the functionality of the addon.

AFAIK, that's the only round one that works out-of-the-box. Some of the square ones might too, but I haven't tried them yet.

zeress commented 5 years ago

For those wondering, to band-aid fix the default blue rune circles; open "BorderPresets.lua" in a text editor

Find the line ["name"] = "Fade", Then below edit scale to be just 0

Save, then reload the preset in-game

KlassyKylie commented 5 years ago

Thank you for responding. Bummed that it most of them don’t work correctly BUT cannot wait for it to be fixed. Thank you for all your hard work. You are doing awesome and we do appreciate it.

dreamscape89 commented 5 years ago

You'd think some textures that just need a pathway would be updated by now... mean...it's been a month or so...

KlassyKylie commented 5 years ago

@dreamscape89, do you want to be the one to sit for hours on end doing all that work for some maps....?

Firegodd commented 5 years ago

@funkydude hey is there an eta on the fix yet?

KlassyKylie commented 5 years ago

@firegodd

The "green textures" will happen in pretty much all the default styles. It's because a lot of the textures being used no longer exist in classic, so show as green instead. I will need to extract them from live and package them in the classic zip.

It will take some time and is not top priority compared to fixing bugs. Being abusive about it will just get your comment deleted and/or banned, it will not speed up the process. If anything, it will do the opposite.

In regards to your 2nd point of addons not showing: SexyMap only supports addons using the LibDBIcon library. If an addon decides to go the route of purposely creating their own custom minimap button, that's their choice. But, their button will not show up in SexyMap.

I will not chase after every addon to make sure their buttons show up - it's up to the addon author to take the friendlier approach of using the community library.

This problem is not unique to classic, but most popular addons already use the library.

delabarra commented 4 years ago

You can set Fade texture path to 165630 and it will be fixed.

ramenkup commented 4 years ago

Necroing this thread. Any developments on this issue? Really hoping to finally use those sex blue rune circles without any green :)

funkydude commented 3 years ago

Closing this since it's no longer relevant for Burning Crusade Classic.

adambowles commented 3 years ago

I still have green textures in TBC Classic

ramenkup commented 3 years ago

adam, Im on BC, and I reset the border preset to default for you and I had no green square. in classic, I had to disable/size to nothing- one of the borders under the current borders tab. It didnt affect the apperance at all, but it did remove the square. hope this helps.

ramenkup commented 3 years ago

I think you just turn fade down to zero.

adambowles commented 3 years ago

For me, the default (ugly as hell) profile is fine: image But some of the other defaults are still green: Electric: image Rustic: image Clouds: image Emerald Portal: image Space: image

funkydude commented 3 years ago

It's unlikely this will change, but I'm sure an upcoming classic expansion will eventually bundle the required textures. Locking.

funkydude commented 2 years ago

Green squares for the default presets are now finally resolved in the latest release by bundling all the missing textures.