Gkjh/#55#64 - Githubissues

funkyfuture / deck-chores

A job scheduler for Docker containers, configured via labels.

https://deck-chores.readthedocs.io/

ISC License

197 stars 27 forks source link

Gkjh/#55#64 #68

Closed garrythezany closed 3 years ago

garrythezany commented 3 years ago

Hello again!

As suggested, I've closed the old pull-request. Excuse me for the long delay but finally I found the time to wrap it up, hopefully now is everything as desired.

To answer your question, I'd say I'm working in the hosting sector. :)

And again thanks for your time!

Garret

funkyfuture commented 3 years ago

i haven't looked too deeply into it, but it seems mostly fine. when you fixed the tests, please also add some that test the validity (both positive and negative) of the job name patterns, in particular regarding the dots.

notes to self:

minor style cosmetics
verify hyperlinks in rendered docs

garrythezany commented 3 years ago

Hello!

I fixed / added lines to the tests as desired, but I wasn't possible for me to force the monkeypatch to actively set the JOB_NAME_REGEX in another test - now the total cover is <90% and I won't have the time to fix this (I'm not reeaaally a python-dev).

Thanks for your time!

Garret

funkyfuture commented 3 years ago

okay, i figured that testing for regex patterns that would allow dots isn't possible concisely. please watch this repo and handle all issues that stem from a misconfiguration of job name patterns! ;-)

funkyfuture commented 3 years ago

These changes have been merged as 05072fe9c71038468d16870d0020e924dbc3dff2 and 8891a586f79f8ae18ac8e850cb3f9c89a02dc17f.