funkyg / funkytunes

A streaming music player for Android, using torrents.
GNU General Public License v3.0
122 stars 24 forks source link

Change Pirate Bay proxy to pirateproxy.cc #10

Closed gjedeer closed 7 years ago

gjedeer commented 7 years ago

This closes #7 and #4 and makes FunkyTunes finally work on my phone.

gjedeer commented 7 years ago

I've added trying mutiple domain names. In my tests I added theproxypirate.pw as the first domain and it gracefully used pirateproxy.cc which was not on the list. Since theproxypirate.pw seems to be completely dead, I did not include it in the pull request.

What I'm not sure about is: should the program also retry when HTML parsing failed? It would be pretty easy to implement and would work around ISPs that return a HTTP/200 response with some message in it.

funkyg commented 7 years ago

Cool! I think that checking for http error codes is enough. Otherwise we can still change that if someone complains.

gjedeer commented 7 years ago

Fixed the problems you mentioned and squashed my commits.

funkyg commented 7 years ago

thanks :)